Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster dep resolution #7

Open
sc0ttj opened this issue Dec 1, 2019 · 0 comments
Open

Faster dep resolution #7

sc0ttj opened this issue Dec 1, 2019 · 0 comments

Comments

@sc0ttj
Copy link
Collaborator

sc0ttj commented Dec 1, 2019

FYI, getting much faster dep resolution is not gonna be too hard, cos Pkg list_deps func has some bugs and bad code - very inefficient .. and get_pkg_name() is probably over-used..

It loops over duplicates lots of times, cos the code to remove the duplicates (IIRC) is broken.

The logic is also basic, and could be improved - the code that generates the dep tree in PPM is where I wanted to look for ideas..

Also the find_deps function, which splits the list form list_deps into 2 lists (installed or not) is also slow .. just cos the code is basic, not cos it does anything clever...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant