Update index page of Command for GA #4833
Conversation
|
Your site preview for commit 736ce9b is ready! 🎉 http://registry--origin-pr-4833-736ce9b4.s3-website.us-west-2.amazonaws.com/registry. |
There was a problem hiding this comment.
Hey @thomas11, I noticed the chooser was kind of broken and the JS examples didn't quite work, so I took the liberty of pushing a commit to save you the hassle of fixing these things up. Hope that's ok!
Approving to unblock, but re this one:
Regarding the EC2/copy example: it spends about ~22 lines on provisioning an EC2 instance with pulumi-aws, with no usage of Command. I think it might be good to remove that part.
I agree -- and what's worse it that the relevant parts aren't even visible in the snippet because it's being cropped. Definitely support swapping this out with something else, but will leave that to you.
How about the "Using local.Command with CURL to manage external REST API" example? Do you have code in the other languages for that one?
| This example creates and EC2 instance, and then uses `remote.Command` and `remote.CopyFile` to run commands and copy files to the remote instance (via SSH). Similar things are possible with Azure, Google Cloud and other cloud provider virtual machines. Support for Windows-based VMs is being tracked [here](https://github.com/pulumi/pulumi-command/issues/15). | ||
| This example creates an EC2 instance, and then uses `remote.Command` and `remote.CopyToRemote` to run commands and copy files to the remote instance (via SSH). Similar things are possible with Azure, Google Cloud and other cloud provider virtual machines. Support for Windows-based VMs is being tracked [here](https://github.com/pulumi/pulumi-command/issues/15). |
There was a problem hiding this comment.
Ah, looks like the affected examples will be captured in pulumi/examples#1654.
Filed this for the content stuff: pulumi/docs#12166
Feel free to add anything else to that list that seems relevant. (Just want to make sure we cover any breaking changes beyond CopyFile.)
There was a problem hiding this comment.
CopyFile still works, it just has a deprecation notice. This is also explained in the blog post. So IMO we don't need anything else here.
|
Your site preview for commit 3c43bb2 is ready! 🎉 http://registry--origin-pr-4833-3c43bb20.s3-website.us-west-2.amazonaws.com/registry. |
thomas11
force-pushed
the
tkappler/command-index
branch
from
2401f2a to
33dd4f4
Compare
|
Your site preview for commit 33dd4f4 is ready! 🎉 http://registry--origin-pr-4833-33dd4f49.s3-website.us-west-2.amazonaws.com/registry. |
thomas11
force-pushed
the
tkappler/command-index
branch
from
9974a5c to
8a09f22
Compare
|
Your site preview for commit 8a09f22 is ready! 🎉 http://registry--origin-pr-4833-8a09f228.s3-website.us-west-2.amazonaws.com/registry. |
Thank you, I appreciate it!
I swapped it out. The actual copy and command are still the same.
That's the only one remaining where I don't have code in other languages yet. |
|
Site previews for this pull request have been removed. ✨ |
Basically
Regarding the EC2/copy example: it spends about ~22 lines on provisioning an EC2 instance with pulumi-aws, with no usage of Command. I think it might be good to remove that part. I have working code in all languages that assumes the remote server exists and takes its IP as a config.