Move the /pkg/pf/README.md user facing docs into /docs
#2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by pulumi/pulumi-tf-provider-boilerplate#169, where it will be helpful to have a place to link to in our docs site.
iwahbe
commented
Dec 12, 2024
| @@ -60,8 +60,7 @@ Terraform provider, see [MuxWith](./muxwith.md). | |||
| ## Pulumi Bridge for Terraform Plugin Framework | |||
|
|
|||
| For instructions on bridging a Terraform provider built using the [Terraform Plugin | |||
| Framework](https://developer.hashicorp.com/terraform/plugin/framework), please see | |||
| [pf/README.md](../pf/README.md). | |||
| Framework](https://developer.hashicorp.com/terraform/plugin/framework), please see [New PF Provider](./new-pf-provider.md). | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2734 +/- ##
==========================================
- Coverage 69.57% 69.56% -0.01%
==========================================
Files 301 301
Lines 38654 38654
==========================================
- Hits 26893 26890 -3
- Misses 10242 10244 +2
- Partials 1519 1520 +1 ☔ View full report in Codecov by Sentry. |
iwahbe
added a commit
to pulumi/pulumi-tf-provider-boilerplate
that referenced
this pull request
Dec 12, 2024
VenelinMartinov
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Looks good, can you verify that all references to PF README point to the correct place?
E.g: https://github.com/pulumi/pulumi-terraform-bridge/blob/master/README.md#upgrading-an-existing-bridged-provider still points to pf/README
iwahbe
added a commit
to pulumi/pulumi-tf-provider-boilerplate
that referenced
this pull request
Dec 12, 2024
|
This PR has been shipped in release v3.98.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by pulumi/pulumi-tf-provider-boilerplate#169, where it will be helpful to have a place to link to in our docs site.