-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed diff tests for properties with dot in the name #2671
Draft
VenelinMartinov
wants to merge
1
commit into
master
Choose a base branch
from
vvm/diff_property_with_dot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
=======================================
Coverage 68.87% 68.88%
=======================================
Files 300 300
Lines 38624 38624
=======================================
+ Hits 26602 26605 +3
+ Misses 10508 10506 -2
+ Partials 1514 1513 -1 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 26, 2024 11:55
018d734
to
bc07e11
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 26, 2024 11:55
3b080be
to
28c249d
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 26, 2024 11:57
bc07e11
to
3f869cb
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 26, 2024 11:57
28c249d
to
f0c8f30
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 26, 2024 12:57
3f869cb
to
1d232e8
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 26, 2024 12:57
f0c8f30
to
45340a5
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 26, 2024 16:02
1d232e8
to
4eeafda
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 26, 2024 16:02
45340a5
to
4c8c818
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 27, 2024 11:00
4eeafda
to
7f1830a
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 27, 2024 11:00
4c8c818
to
6a0138c
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
November 27, 2024 11:22
7f1830a
to
43cc58d
Compare
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 27, 2024 11:22
6a0138c
to
1d19492
Compare
Base automatically changed from
vvm/sdkv2_diff_tests_computed_forcenew
to
master
November 27, 2024 12:45
VenelinMartinov
force-pushed
the
vvm/diff_property_with_dot
branch
from
November 27, 2024 12:53
1d19492
to
6fa352c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties with dots in their names are not correctly returned by both the old and new detailed diff algorithm. This change adds a unit tests and integration tests for both the old and new detailed diff algorithms.
Related to #2669