Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed diff tests for properties with dot in the name #2671

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 26, 2024

Properties with dots in their names are not correctly returned by both the old and new detailed diff algorithm. This change adds a unit tests and integration tests for both the old and new detailed diff algorithms.
Related to #2669

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 26, 2024

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (1aa2e64) to head (6fa352c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2671   +/-   ##
=======================================
  Coverage   68.87%   68.88%           
=======================================
  Files         300      300           
  Lines       38624    38624           
=======================================
+ Hits        26602    26605    +3     
+ Misses      10508    10506    -2     
+ Partials     1514     1513    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as draft November 26, 2024 11:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 018d734 to bc07e11 Compare November 26, 2024 11:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from 3b080be to 28c249d Compare November 26, 2024 11:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from bc07e11 to 3f869cb Compare November 26, 2024 11:57
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from 28c249d to f0c8f30 Compare November 26, 2024 11:57
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 3f869cb to 1d232e8 Compare November 26, 2024 12:57
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from f0c8f30 to 45340a5 Compare November 26, 2024 12:57
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 1d232e8 to 4eeafda Compare November 26, 2024 16:02
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from 45340a5 to 4c8c818 Compare November 26, 2024 16:02
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 4eeafda to 7f1830a Compare November 27, 2024 11:00
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from 4c8c818 to 6a0138c Compare November 27, 2024 11:00
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 7f1830a to 43cc58d Compare November 27, 2024 11:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_property_with_dot branch from 6a0138c to 1d19492 Compare November 27, 2024 11:22
Base automatically changed from vvm/sdkv2_diff_tests_computed_forcenew to master November 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant