Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent map write in declareRuntimeMetadata #2728

Closed
t0yv0 opened this issue Dec 11, 2024 · 0 comments · Fixed by #2733
Closed

Concurrent map write in declareRuntimeMetadata #2728

t0yv0 opened this issue Dec 11, 2024 · 0 comments · Fixed by #2733
Assignees
@iwahbe
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Dec 11, 2024

What happened?

Suspect this code:

pulumi-terraform-bridge/pkg/tfbridge/metadata.go

Line 37 in f8f86a6

var declaredRuntimeMetadata = map[string]struct{}{

To trigger "concurrent map writes" panic in the test suite in https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/12283355952/job/34282617115?pr=2718#step:9:2935

Would it be possible to remove this shared state ?

Example

See above.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 11, 2024
iwahbe added a commit that referenced this issue Dec 12, 2024
@iwahbe
Protect declaredRuntimeMetadata with a sync.Mutex
4dfb580 
Fixes #2728
iwahbe added a commit that referenced this issue Dec 12, 2024
@iwahbe
Protect declaredRuntimeMetadata with a sync.Mutex
454428a 
This should fix the immediate issue. We should probably refactor this to avoid the global,
but that can be done later.

Fixes #2728
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Dec 12, 2024
@iwahbe iwahbe self-assigned this Dec 12, 2024
@iwahbe iwahbe mentioned this issue Dec 12, 2024
Merged
iwahbe added a commit that referenced this issue Dec 13, 2024
@iwahbe
Protect declaredRuntimeMetadata with a sync.Mutex (#2733)
f7f43b6 
This should fix the immediate issue. We should probably refactor this to
avoid the global, but that can be done later.

Fixes #2728
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect declaredRuntimeMetadata with a sync.Mutex pulumi/pulumi-terraform-bridge
3 participants
@t0yv0 @iwahbe @pulumi-bot