Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] WIP Cross-testing for Configure #2700

Open
2 tasks
iwahbe opened this issue Dec 9, 2024 · 0 comments
Open
2 tasks

[EPIC] WIP Cross-testing for Configure #2700

iwahbe opened this issue Dec 9, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user kind/epic Large new features or investments

Comments

@iwahbe
Copy link
Member

iwahbe commented Dec 9, 2024

We have made tremendous progress on testing in the bridge: cross-test, providertest and replay testing have made it much easier to write and maintain high quality tests of the bridge. cross-test has crucially allowed us to start comparing our behavior directly to Terraform. Now that we've written the testing libraries, we need to actually write tests.

In testing configure, we need to assert that values passed into Configure are available later on (in resources and datasources). Since the engine always passes secrets on Configure.

In addition to TF cross-tests, we need to test the behavior of resources and datasources when a provider is configured with an unknown value.

SDKv2

Each issue corresponds to a file1 in pkg/tfbridge/tests/. The expectation is that future (and current) maintainers should be able to check if a feature is under test by going searching for a test file in pkg/tfbridge/tests/ that applies to the area under test.

PF

Each issue corresponds to a file1 in pkg/pf/tfbridge2.

Cross-test improvements

Footnotes

  1. The file may already exist, or it may need to be created. 2

  2. The path is different for PF and SDKv2 because SDKv2 cross-tests transitively imports pkg/tfbridge.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 9, 2024
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user kind/epic Large new features or investments and removed needs-triage Needs attention from the triage team labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user kind/epic Large new features or investments
Projects
None yet
Development

No branches or pull requests

2 participants