Skip to content

Commit

Permalink
Add todo for matching replayed logs (#2572)
Browse files Browse the repository at this point in the history
We can consider a cleverer method of matching logs for dynamic replay
tests. This PR adds a TODO in case someone hits this.

Addresses
#2484 (comment)
  • Loading branch information
VenelinMartinov authored Nov 1, 2024
1 parent 0603908 commit 3efb90b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions dynamic/internal/shim/grpcutil/replay.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ func NewLogReplayProvider(name, version string, logs []byte) LogReplayProvider {
func (p LogReplayProvider) mustPopLog(method string) grpcLog {
logs, ok := p.methodLogs[method]
contract.Assertf(ok && len(logs) > 0, "no logs for method %s, logs: %s", method, p.methodLogs)
// TODO[pulumi/pulumi-terraform-bridge#2571]: Consider a cleverer way of matching multiple logs for the same method.
log := logs[0]
logs = logs[1:]
p.methodLogs[method] = logs
Expand Down

0 comments on commit 3efb90b

Please sign in to comment.