Fix await annotation precedence #3344
Merged
+82
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
approved these changes
Dec 3, 2024
| @@ -5,6 +5,11 @@ | |||
| - [nodejs] Resolves `punycode` deprecation warnings by using native `fetch` instead of `node-fetch`. | |||
| (https://github.com/pulumi/pulumi-kubernetes/issues/3301) | |||
|
|
|||
| ### Fixed | |||
|
|
|||
There was a problem hiding this comment.
Should we also add a note about jsonpath matching on complex types?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
+ Coverage 41.08% 41.11% +0.03%
==========================================
Files 85 85
Lines 12736 12741 +5
==========================================
+ Hits 5232 5238 +6
+ Misses 7115 7113 -2
- Partials 389 390 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when creating or updating, custom await annotations (including
waitForandskipAwait) will be ignored for resources which have built-in await logic.This corrects the behavior by returning a boolean from
metadata.ReadyConditionindicating whether the user specified some behavior via an annotation. If that's true then we don't use the built-in logic.We preserve the existing precedence when
PULUMI_K8S_AWAIT_ALListrue. That is, we will continue to use built-in await logic (if the resource has it) by default, even when generic await is enabled.During testing I also realized we have a bug where if a JSONPath is specified pointing to a non-primitive type (like
.metadata) it will never resolve. I fixed this to match correctly.Refs #3329
Fixes #3345