Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Adds interpolate content to apply page #4151

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

toriancrane
Copy link
Contributor

Description

This PR adds interpolate helper content to the Apply page.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 30c7f21 is ready! 🎉

http://pulumi-hugo-origin-pr-4151-30c7f21e.s3-website.us-west-2.amazonaws.com.

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "fixes" the absence of this content on this page, but now we have two pieces of content on two separate pages that duplicates and must be maintained independently. This also leaves us with the related problem of having the JSON helpers on the Apply page, but still not on the All page.

I really do think the proper solution here is just to give the helpers a page of their own, as I've suggested, and link to this page from both the Apply and All pages. There are benefits to this beyond just not having the duplication as well -- discoverability, clarity/distinguishing from Apply and All as I've mentioned, room for more examples, room for more helpers as we add them, etc. I'd much rather see us do this than duplicate this content (and presumably the JSON helper content as well). The effort should minimal since we've already written pretty much all of the content we need already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants