Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repository lock from V3 Collection Import endpoint #1115

Closed
wants to merge 1 commit into from

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Jul 8, 2022

fixes: #1105

Right now this is the bare minimum changes required to remove the repository lock from the initial import task. However, I think we should look into changing the CollectionImport model to accommodate for the new task group which would require a migration. @newswangerd

TODO:

  • Add/modify current tests
  • Decide on how much info the CollectionImport model should report

@pep8speaks
Copy link

pep8speaks commented Jul 8, 2022

Hello @gerrod3! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-08 23:45:50 UTC

with repository.new_version() as new_version:
new_version.add_content(content_q)
CreatedResource.objects.create(content_object=repository)
if not lockless:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try to see if the repository was in the locks of this task and decide that way.
WDYT?

@newswangerd
Copy link
Contributor

@gerrod3 I think we need to make some additional changes to the collection import changes anyway. There are some fields that are missing which are in the galaxy_ng implementation

@gerrod3
Copy link
Contributor Author

gerrod3 commented Jul 12, 2022

@gerrod3 I think we need to make some additional changes to the collection import changes anyway. There are some fields that are missing which are in the galaxy_ng implementation

I see the galaxy collection import has a reference to the namespace model. So this work needs to wait till the namespace model has been moved.

@stale
Copy link

stale bot commented Oct 10, 2022

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Oct 10, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlock repository during collection import
4 participants