-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add PR workflow and related facilities
[noissue]
- Loading branch information
Showing
8 changed files
with
155 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import os | ||
import re | ||
import subprocess | ||
import sys | ||
from pathlib import Path | ||
|
||
import toml | ||
from github import Github | ||
|
||
KEYWORDS = ["fixes", "closes"] | ||
BLOCKING_REGEX = [ | ||
"DRAFT", | ||
"WIP", | ||
"NOMERGE", | ||
r"DO\s*NOT\s*MERGE", | ||
"EXPERIMENT", | ||
] | ||
NO_ISSUE = "[noissue]" | ||
CHANGELOG_EXTS = [ | ||
f".{item['directory']}" for item in toml.load("pyproject.toml")["tool"]["towncrier"]["type"] | ||
] | ||
|
||
sha = sys.argv[1] | ||
message = subprocess.check_output(["git", "log", "--format=%B", "-n 1", sha]).decode("utf-8") | ||
|
||
if any((re.match(pattern, message) for pattern in BLOCKING_REGEX)): | ||
sys.exit("This PR is not ready for consumption.") | ||
|
||
g = Github(os.environ.get("GITHUB_TOKEN")) | ||
repo = g.get_repo("pulp/pulp-cli") | ||
|
||
|
||
def check_status(issue): | ||
gi = repo.get_issue(int(issue)) | ||
if gi.pull_request: | ||
sys.exit(f"Error: issue #{issue} is a pull request.") | ||
if gi.closed_at: | ||
sys.exit(f"Error: issue #{issue} is closed.") | ||
|
||
|
||
def check_changelog(issue): | ||
matches = list(Path("CHANGES").rglob(f"{issue}.*")) | ||
|
||
if len(matches) < 1: | ||
sys.exit(f"Could not find changelog entry in CHANGES/ for {issue}.") | ||
for match in matches: | ||
if match.suffix not in CHANGELOG_EXTS: | ||
sys.exit(f"Invalid extension for changelog entry '{match}'.") | ||
|
||
|
||
print("Checking commit message for {sha}.".format(sha=sha[0:7])) | ||
|
||
# validate the issue attached to the commit | ||
issue_regex = r"(?:{keywords})[\s:]+#(\d+)".format(keywords=("|").join(KEYWORDS)) | ||
issues = re.findall(issue_regex, message, re.IGNORECASE) | ||
cherry_pick_regex = r"^\s*\(cherry picked from commit [0-9a-f]*\)\s*$" | ||
cherry_pick = re.search(cherry_pick_regex, message, re.MULTILINE) | ||
|
||
if issues: | ||
for issue in issues: | ||
if not cherry_pick: | ||
check_status(issue) | ||
check_changelog(issue) | ||
else: | ||
if NO_ISSUE in message: | ||
print("Commit {sha} has no issues but is tagged {tag}.".format(sha=sha[0:7], tag=NO_ISSUE)) | ||
else: | ||
sys.exit( | ||
"Error: no attached issues found for {sha}. If this was intentional, add " | ||
" '{tag}' to the commit message.".format(sha=sha[0:7], tag=NO_ISSUE) | ||
) | ||
|
||
print("Commit message for {sha} passed.".format(sha=sha[0:7])) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: "Build" | ||
|
||
on: | ||
workflow_call: | ||
|
||
jobs: | ||
build: | ||
runs-on: "ubuntu-latest" | ||
steps: | ||
- uses: "actions/checkout@v4" | ||
- name: "Set up Python" | ||
uses: "actions/setup-python@v5" | ||
with: | ||
python-version: "3.11" | ||
- name: "Install python dependencies" | ||
run: | | ||
pip install build setuptools wheel | ||
- name: "Build wheels" | ||
run: | | ||
make build | ||
- name: "Upload wheels" | ||
uses: "actions/upload-artifact@v4" | ||
with: | ||
name: "pulp_docs_package" | ||
path: | | ||
dist/ | ||
if-no-files-found: "error" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
name: "Docs" | ||
|
||
on: | ||
workflow_call: | ||
|
||
jobs: | ||
test: | ||
runs-on: "ubuntu-20.04" | ||
steps: | ||
- uses: "actions/checkout@v4" | ||
- name: "Set up Python" | ||
uses: "actions/setup-python@v5" | ||
with: | ||
python-version: "3.11" | ||
- name: "Install Test Dependencies" | ||
run: | | ||
pip install -r doc_requirements.txt | ||
- name: Build docs | ||
run: make docs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: "pulp-docs CI" | ||
|
||
on: | ||
pull_request: | ||
|
||
concurrency: | ||
group: "main-${{ github.ref_name }}-${{ github.workflow }}" | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
build: | ||
uses: "./.github/workflows/build.yml" | ||
docs: | ||
needs: | ||
- "build" | ||
uses: "./.github/workflows/docs.yml" | ||
ready-to-ship: | ||
# This is a dummy dependent task to have a single entry for the branch protection rules. | ||
runs-on: "ubuntu-latest" | ||
needs: | ||
- "docs" | ||
if: "always()" | ||
steps: | ||
- name: "Collect needed jobs results" | ||
run: | | ||
echo '${{toJson(needs)}}' | jq -r 'to_entries[]|select(.value.result!="success")|.key + ": " + .value.result' | ||
echo '${{toJson(needs)}}' | jq -e 'to_entries|map(select(.value.result!="success"))|length == 0' | ||
echo "CI says: Looks good!" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
build: | ||
pyproject-build -n | ||
|
||
docs: | ||
pulp-docs build | ||
|
||
.PHONY: build docs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
. |
Submodule new_repo1
deleted from
1a090a