Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aria-required-children and html-has-lang accessibility violations on series listing page #152

Open
4 tasks
vh8154 opened this issue Nov 1, 2024 · 0 comments

Comments

@vh8154
Copy link
Contributor

vh8154 commented Nov 1, 2024

Steps to recreate

  1. Go to Repec series listing page
  2. Run Axe DevTools on this page

URL

https://repec-prod.princeton.edu/

Issues

  • Certain ARIA roles must contain particular children
  • html element must have a lang attribute

Severity

Critical

WCAG Success Criterion

WCAG 1.3.1 Info and Relationships (Level A)
WCAG 3.1.1 Language of Page

WCAG Conformance level (A, AA, AAA)

A

User impact

  1. Certain ARIA roles not having particular children can cause confusion for assistive technologies such as screen readers to convey information accurately.
  2. Screen readers use the lang attribute to determine the language of content and without it, users may hear the wrong pronunciations or intonations.

Recommended fix

  1. To solve this problem, you need to fix the following: Element has children which are not allowed: [role=search]
  2. To solve this problem, you need to fix the following: The element does not have a lang attribute

Acceptance criteria

  • When removing pending in the accessibility_spec for the series listing page, rspec tests run without error.
  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
  • ...

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant