Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cmake file for not ESP32 builds #188

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix cmake file for not ESP32 builds #188

merged 2 commits into from
Jun 28, 2024

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Jun 28, 2024

fix: fix cmake build for not ESP32 builds

Fixed cmake build for not ESP32 builds

@Xavrax Xavrax requested review from parfeon and seba-aln as code owners June 28, 2024 08:41
seba-aln
seba-aln approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@seba-aln seba-aln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely well done work! You can see the years at university finally paying off!
Love it!

@Xavrax
Copy link
Contributor Author

Xavrax commented Jun 28, 2024

@pubnub-release-bot release

@Xavrax Xavrax merged commit d36b8dd into master Jun 28, 2024
6 checks passed
@Xavrax Xavrax deleted the fix/cmake-build branch June 28, 2024 09:07
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seba-aln seba-aln seba-aln approved these changes

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavrax @pubnub-release-bot @seba-aln