Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings in objects API #185

Merged
merged 17 commits into from
Jun 14, 2024
Merged

strings in objects API #185

merged 17 commits into from
Jun 14, 2024

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Jun 7, 2024

feat: possibility to use string in actions API

Added possibility to use strings in actions API

refactor: pubnub_action_type deprecated

pubnub_action_type enum has been deprecated

@Xavrax Xavrax requested review from parfeon and seba-aln as code owners June 7, 2024 12:41
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but still some questions :)

core/pbcc_actions_api.c Outdated Show resolved Hide resolved
core/pbcc_actions_api.c Outdated Show resolved Hide resolved
core/pbcc_actions_api.c Outdated Show resolved Hide resolved
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pubnub pubnub deleted a comment from Xavrax Jun 14, 2024
@pubnub pubnub deleted a comment from Xavrax Jun 14, 2024
@parfeon
Copy link
Contributor

parfeon commented Jun 14, 2024

@pubnub-release-bot release as v4.10.0

@Xavrax Xavrax changed the title add new options to enum in actions API strings in objects API Jun 14, 2024
@parfeon parfeon merged commit c0910f6 into master Jun 14, 2024
6 checks passed
@parfeon parfeon deleted the feat/actions-api branch June 14, 2024 08:53
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants