move pubnub_qt into main thread
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavrax
requested review from
techwritermat,
kazydek,
kleewho and
parfeon
as code owners
|
tested on MacOs - works as expected |
|
tested on Windows - works as expected |
techwritermat
approved these changes
Oct 27, 2023
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: move
pubnub_qtinto QT main threadMove
pubnub_qtinto QT main thread by default to be sure that timers will be run in itfeat: add
PUBNUB_QT_MOVE_TO_THREADflag as defaultAdd the
PUBNUB_QT_MOVE_TO_THREADflag as default to give users the opportunity to manage threads by themselves.