Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename v0.3 Range into BoundedRange #123

Open
mpizenberg opened this issue Oct 22, 2022 · 6 comments
Open

Rename v0.3 Range into BoundedRange #123

mpizenberg opened this issue Oct 22, 2022 · 6 comments

Comments

@mpizenberg
Copy link
Member

I'm currently writing the v0.2 -> v0.3 upgrade guide and realizing we still have the name Range for our default impl of VersionSet. However, this is not exactly the same as the previous v0.2 Range.
So to prevent user confusion, and also make the upgrade guide clearer, I'd suggest we rename it to BoundedRange.
That's also more precise since it's a range built with inclusive/exclusive bounds.

@baszalmstra
Copy link
Contributor

Sounds good!

@mpizenberg mpizenberg added this to the v0.3 milestone Oct 22, 2022
@Eh2406 Eh2406 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 27, 2023
@Michaelin007
Copy link

Hi, I would like to work on this issue.
Where's the upgrade guide location?
Thanks

@mpizenberg
Copy link
Member Author

Hi @Michaelin007 thanks for your interest in this! The upgrade guide currently lives in the pubgrub-rs/guide repo, in a pull request I did not finish. pubgrub-rs/guide#6

You might have to coordinate with @Eh2406 and @charliermarsh who started reading that guide and leaving some comments.

I'm not currently working on the guide so no need to coordinate with me. I'm happy to answer questions though.

@Michaelin007
Copy link

Hi @mpizenberg noted.
Thanks

@Eh2406
Copy link
Member

Eh2406 commented Nov 6, 2023

Let's focus on making the change here. We can deal with updating the guide once the code has been changed.

@konstin konstin removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 30, 2024
@konstin
Copy link
Member

konstin commented Oct 30, 2024

With the version-ranges crate split out (#262), the type's main name is now Ranges, which the old Range name being reexported for compatibility.

@konstin konstin removed this from the v0.3 VersionSet trait milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants