Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Webpacker to compile JS assets #64

Closed
5 tasks done
banukutlu opened this issue Sep 21, 2018 · 5 comments
Closed
5 tasks done

Use Webpacker to compile JS assets #64

banukutlu opened this issue Sep 21, 2018 · 5 comments
Assignees
Labels

Comments

@banukutlu
Copy link
Contributor

In GitLab by @bzk60 on Jul 16, 2018, 15:25

https://github.com/projectblacklight/blacklight/wiki/Using-Webpacker-to-compile-javascript-assets
https://www.npmjs.com/package/blacklight-frontend

@banukutlu banukutlu added this to the Black CAT Prerelease milestone Sep 21, 2018
@banukutlu
Copy link
Contributor Author

In GitLab by @cdm32 on Jul 17, 2018, 08:12

@bzk60, will you be looking into...

Sprockets

?

@banukutlu
Copy link
Contributor Author

In GitLab by @bzk60 on Jul 17, 2018, 09:46

@cdm32 nope since now that you got the assets loaded using webpacker :)

@banukutlu
Copy link
Contributor Author

In GitLab by @bzk60 on Jul 17, 2018 9:46

@cdm32 nope since now that you got the assets loaded using webpacker :)

@banukutlu
Copy link
Contributor Author

In GitLab by @cdm32 on Jul 17, 2018 9:50

this was the missing piece: twbs/bootstrap#23381 (comment)

everything else wasn't needed

i told justin coyne about it, hopefully he will update https://github.com/projectblacklight/blacklight/wiki/Using-Webpacker-to-compile-javascript-assets

i guess i could but that seems out of step

@banukutlu
Copy link
Contributor Author

In GitLab by @cdm32 on Jul 17, 2018 13:40

two things ain't working still:

// require('blacklight-frontend/app/javascript/blacklight/checkbox_submit')
// require('blacklight-frontend/app/javascript/blacklight/bookmark_toggle')

uncommenting results in errors.

also we need to document dev instructions

also we need to know how to deploy to prod before we can call this done for real

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants