-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search doesnt work in certain websites #4
Comments
Confirming. It seem to not work on GMail. Will have to find out why. |
on a lighter note, is this plugin really used it GMail likes pages where the GMail search itself is really neat. I totally agree that what if someone sends you a patch to your gmail. But on a more used sense? |
@kvijesh I am sorry I missed answering this question earlier. But I didn't understand your question fully though. I will try to answer based on how I understood. Please re-ask if not satisfactory. You are correct that such a feature may not be much useful in GMail. But I will be happy to get any patch that solves this problem. Actually this is a issue with the highlighter javascript so it will be helpful for others as well :-) |
My question was how many times practically we would want to search in |
@kvijesh ah okay. Yes, As you said it may not be very useful practically. But fixing this may help in fixing the same issue in some other website where it may be more relevant :-) But yes, I agree that it is not a very useful fix when it comes to gmail. |
Steps to reproduce:
URL : https://chrome.google.com/webstore/detail/phabnclfbnmhmoipebjdfhkiacojlcnc#
Search string : the
or
URL : www.gmail.com
Search string : the
The text was updated successfully, but these errors were encountered: