-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRU2024 #188
SRU2024 #188
Changes from 24 commits
2cd94b7
12ff4be
effcdfb
95bb956
909b517
51a91c0
dd9e9ce
ca98542
e6364b8
abe25b2
5574ec1
e9584f1
ad76754
de92a77
bfe88e2
084577d
8ac48f9
7db754e
c98ac9e
bdea5a5
ddab106
ad4f4b2
b8ba86f
101d358
156284f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,15 +1,25 @@ | ||||||||||||||||||||||||||||||||||
# Prowide Core - CHANGELOG | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
#### 9.4.19 - SNAPSHOT | ||||||||||||||||||||||||||||||||||
#### 9.5.3 - November 2024 | ||||||||||||||||||||||||||||||||||
* (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||||||||||||||||||||||||||||||||||
* (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||||||||||||||||||||||||||||||||||
* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||||||||||||||||||||||||||||||||||
* Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||||||||||||||||||||||||||||||||||
* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
#### 9.4.18 - October 2024 | ||||||||||||||||||||||||||||||||||
#### 9.5.2 - October 2024 | ||||||||||||||||||||||||||||||||||
* Added new `FieldEnum` with all the available field names | ||||||||||||||||||||||||||||||||||
* Code security improvements as per CodeQL recommendations | ||||||||||||||||||||||||||||||||||
Comment on lines
+10
to
12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Standardize bullet point indentation. The bullet points should use single-space indentation for consistency. Apply this formatting: #### 9.5.2 - October 2024
- * Added new `FieldEnum` with all the available field names
- * Code security improvements as per CodeQL recommendations
+* Added new `FieldEnum` with all the available field names
+* Code security improvements as per CodeQL recommendations 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint11-11: Expected: 0; Actual: 2 (MD007, ul-indent) 12-12: Expected: 0; Actual: 2 (MD007, ul-indent) 10-10: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings) 11-11: null (MD032, blanks-around-lists) |
||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
Comment on lines
+10
to
13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Standardize bullet point indentation. The bullet points should use single-space indentation for consistency. Apply this formatting: #### 9.5.2 - October 2024
- * Added new `FieldEnum` with all the available field names
- * Code security improvements as per CodeQL recommendations
+* Added new `FieldEnum` with all the available field names
+* Code security improvements as per CodeQL recommendations 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint11-11: Expected: 0; Actual: 2 (MD007, ul-indent) 12-12: Expected: 0; Actual: 2 (MD007, ul-indent) 10-10: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings) 11-11: null (MD032, blanks-around-lists) |
||||||||||||||||||||||||||||||||||
#### 9.4.17 - June 2024 | ||||||||||||||||||||||||||||||||||
#### 9.5.1 - June 2024 | ||||||||||||||||||||||||||||||||||
* (PW-1913) Added IBAN validation for Egypt local account structure | ||||||||||||||||||||||||||||||||||
* Restore deprecated method in MT210 class | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
Comment on lines
+14
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Fix formatting inconsistencies. The entry has inconsistent formatting and an unnecessary empty line between bullet points. Apply this formatting: #### 9.5.1 - June 2024
- * (PW-1913) Added IBAN validation for Egypt local account structure
- * Restore deprecated method in MT210 class
-
+* (PW-1913) Added IBAN validation for Egypt local account structure
+* Restore deprecated method in MT210 class 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint15-15: Expected: 0; Actual: 2 (MD007, ul-indent) 16-16: Expected: 0; Actual: 2 (MD007, ul-indent) 14-14: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings) 15-15: null (MD032, blanks-around-lists) |
||||||||||||||||||||||||||||||||||
#### 9.5.0 - May 2024 | ||||||||||||||||||||||||||||||||||
* SWIFT Standard release update 2024 (live 16 November 2025) | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Document SWIFT Standard 2024 changes comprehensively. The SWIFT Standard Release Update 2024 (SRU2024) is a major change that should be documented more thoroughly, including:
Would you like me to help create a comprehensive section about SRU2024 changes? 🧰 Tools🪛 Markdownlint19-19: Expected: 0; Actual: 2 (MD007, ul-indent) 19-19: null (MD032, blanks-around-lists) |
||||||||||||||||||||||||||||||||||
* Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | ||||||||||||||||||||||||||||||||||
Comment on lines
+19
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Document SWIFT Standard 2024 changes comprehensively. The SWIFT Standard Release Update 2024 (SRU2024) is a major change that should be documented more thoroughly, including:
Would you like me to help create a comprehensive section about SRU2024 changes? 🧰 Tools🪛 Markdownlint19-19: Expected: 0; Actual: 2 (MD007, ul-indent) 20-20: Expected: 0; Actual: 2 (MD007, ul-indent) 19-19: null (MD032, blanks-around-lists) 20-20: null (MD034, no-bare-urls) |
||||||||||||||||||||||||||||||||||
* Dependency update: commons-lang3 -> 3.14.0' | ||||||||||||||||||||||||||||||||||
* Dependency update: gson -> 2.11.0' | ||||||||||||||||||||||||||||||||||
Comment on lines
+21
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Use consistent format for dependency updates. The dependency updates should follow a consistent format and include the reason for the update. Apply this formatting: - * Dependency update: commons-lang3 -> 3.14.0'
- * Dependency update: gson -> 2.11.0'
+* Dependencies:
+ * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements)
+ * Updated gson to 2.11.0 (security fixes and new features) 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint20-20: Expected: 0; Actual: 2 (MD007, ul-indent) 21-21: Expected: 0; Actual: 2 (MD007, ul-indent)
Comment on lines
+18
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix formatting issues in version 9.5.0 entry. The entry has several formatting issues:
Apply this formatting: #### 9.5.0 - May 2024
- * SWIFT Standard release update 2024 (live 16 November 2025)
- * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)
- * Dependency update: commons-lang3 -> 3.14.0'
- * Dependency update: gson -> 2.11.0'
+* SWIFT Standard release update 2024 (live 16 November 2025)
+* Yearly revision of deprecation phase (see [deprecation policy](https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/))
+* Dependencies:
+ * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements)
+ * Updated gson to 2.11.0 (security fixes and new features) 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Markdownlint19-19: Expected: 0; Actual: 2 (MD007, ul-indent) 20-20: Expected: 0; Actual: 2 (MD007, ul-indent) 21-21: Expected: 0; Actual: 2 (MD007, ul-indent) 22-22: Expected: 0; Actual: 2 (MD007, ul-indent) 18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings) 19-19: null (MD032, blanks-around-lists) 20-20: null (MD034, no-bare-urls) |
||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
#### 9.4.16 - May 2024 | ||||||||||||||||||||||||||||||||||
* (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments | ||||||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ archivesBaseName = 'pw-swift-core' | |
group 'com.prowidesoftware' | ||
|
||
project.ext { | ||
SRU = 'SRU2023' | ||
SRU = 'SRU2024' | ||
} | ||
|
||
scmVersion { | ||
|
@@ -34,6 +34,7 @@ scmVersion { | |
} | ||
} | ||
project.version = "${SRU}-${scmVersion.version}" | ||
//project.version = "${SRU}-9.5.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Consider removing the commented-out version override This commented-out line doesn't affect the build but might lead to confusion. If it's no longer needed for version overrides, consider removing it to keep the build file clean. |
||
|
||
tasks.withType(JavaCompile) { | ||
options.encoding = 'UTF-8' | ||
|
@@ -52,20 +53,20 @@ repositories { | |
} | ||
|
||
dependencies { | ||
implementation 'org.apache.commons:commons-lang3:3.12.0' | ||
implementation 'com.google.code.gson:gson:2.9.0' | ||
implementation 'org.apache.commons:commons-lang3:3.14.0' | ||
implementation 'com.google.code.gson:gson:2.11.0' | ||
|
||
compileOnly 'javax.persistence:javax.persistence-api:2.2' | ||
compileOnly 'javax.xml.bind:jaxb-api:2.3.1' | ||
compileOnly 'javax.validation:validation-api:2.0.1.Final' | ||
|
||
testImplementation 'javax.validation:validation-api:2.0.1.Final' | ||
testImplementation 'javax.persistence:javax.persistence-api:2.2' | ||
testImplementation('org.junit.jupiter:junit-jupiter:5.8.2') | ||
testImplementation group: 'org.assertj', name: 'assertj-core', version: '3.22.0' | ||
testImplementation group: 'org.xmlunit', name: 'xmlunit-core', version: '2.9.0' | ||
testImplementation group: 'org.xmlunit', name: 'xmlunit-matchers', version: '2.9.0' | ||
testImplementation group: 'org.xmlunit', name: 'xmlunit-assertj', version: '2.9.0' | ||
testImplementation 'org.junit.jupiter:junit-jupiter:5.10.2' | ||
testImplementation 'org.assertj:assertj-core:3.25.3' | ||
testImplementation 'org.xmlunit:xmlunit-core:2.10.0' | ||
testImplementation 'org.xmlunit:xmlunit-matchers:2.9.0' | ||
testImplementation 'org.xmlunit:xmlunit-assertj:2.9.0' | ||
} | ||
|
||
sourceSets.main.java.srcDirs = ['src/main/java', 'src/generated/java'] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix duplicate entry and standardize version format.
The latest version entry has the following issues:
MtSequenceEnum
additionApply this formatting:
📝 Committable suggestion
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)