You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implement error handling in the addTxToCache method to ensure that when ibcService.saveIbcChannelData fails, the remaining transaction data for the block is still saved, and the failure is logged in a database table.
Problem Definition
Currently, if any part of the addTxToCache method fails, such as the ibcService.saveIbcChannelData(res, txInfo, txUpdate) call, none of the transaction data for that block is saved. This issue is particularly problematic as it leads to missing transaction data in the database. Related issues, like #500 and #502, indicate that this problem may be more widespread than initially reported.
Addressing this issue will significantly improve the reliability of the explorer-service by ensuring data integrity even if parts of the transaction processing fail. It also lays the groundwork for future enhancements with similar error handling for all save operations.
Proposal
Modify the addTxToCache method in the AsyncCachingV2 class to include a try-catch block around the ibcService.saveIbcChannelData(res, txInfo, txUpdate) call.
If the ibcService.saveIbcChannelData call fails, log the error in a new or existing database table dedicated to tracking such failures.
Ensure that the method continues processing and saving the remaining transaction data even if the IBC save operation fails.
For future consideration, extend this error-handling pattern to other save operations within the addTxToCache method.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Implement error handling in the
addTxToCache
method to ensure that whenibcService.saveIbcChannelData
fails, the remaining transaction data for the block is still saved, and the failure is logged in a database table.Problem Definition
Currently, if any part of the
addTxToCache
method fails, such as theibcService.saveIbcChannelData(res, txInfo, txUpdate)
call, none of the transaction data for that block is saved. This issue is particularly problematic as it leads to missing transaction data in the database. Related issues, like #500 and #502, indicate that this problem may be more widespread than initially reported.Addressing this issue will significantly improve the reliability of the explorer-service by ensuring data integrity even if parts of the transaction processing fail. It also lays the groundwork for future enhancements with similar error handling for all save operations.
Proposal
addTxToCache
method in theAsyncCachingV2
class to include a try-catch block around theibcService.saveIbcChannelData(res, txInfo, txUpdate)
call.ibcService.saveIbcChannelData
call fails, log the error in a new or existing database table dedicated to tracking such failures.addTxToCache
method.For Admin Use
The text was updated successfully, but these errors were encountered: