Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues addressed, added export for fmfn files #30

Open
DanShockley opened this issue Apr 21, 2023 · 5 comments
Open

Multiple issues addressed, added export for fmfn files #30

DanShockley opened this issue Apr 21, 2023 · 5 comments

Comments

@DanShockley
Copy link

DanShockley commented Apr 21, 2023

Since this projects has asked for no pull requests, I've taken the fmp12 from my fork, and am attaching it to this "Issue". My fork is at: https://github.com/DanShockley/fm-json-additions

One potentially useful thing is that the database now uses the Save As XML, along with the BaseElements plugin, to create the .fmfn files in the functions directory. So, the attached file might make pull requests more useful in the future, since the FileMaker file can at least update all the .fmfn files itself.

Note that I believe this copy addresses the following issues:

Additional Changes:

  • Added FileMaker script "Export functions" to update/create .fmfn files to match the CURRENT custom functions in the fmp12 file by doing Save Copy as XML (requires BaseElements plugin).
  • Updated all the .fmfn files.
  • renamed table to "RelatedData" instead of "RleatedData"
  • Updated all the test names to be consistent with the function's current name
  • Updated all the test names to include a bit more description of what they test
  • In fmp12 file, widened field showing the test name
  • In fmp12 file, removed the passfail field from tab order

Attached file:
JSONAdditions-2023-04-21-1906.fmp12.zip

@DanShockley
Copy link
Author

Note that the Contributing.md file asks us to apply labels to our issues, but I believe only those with triage access to the repository can apply labels to issues.
I guess this issue would be: bug, enhancement

@DanShockley
Copy link
Author

I did not update the docs.md file, but we could probably modify the Export Functions script to also update that file. It would require some parsing of the function code pulled from the XML file, but is probably doable, especially if the functions all stick to a standard documentation block at the beginning.

@toddgeist
Copy link
Contributor

Thanks for putting so much effort in. I'll take a look at your fork and see what we can do about merging it.

@DanShockley
Copy link
Author

Glad to help! Hopefully benefits us all.
I finished adding "update the docs.md file" to the Export script. That also involved modifying a handful of the functions so they stuck to the same intro documentation block format.
Attached is an updated copy of the fmp12 file.
JSONAdditions-2023-04-22.fmp12.zip

@joshormond
Copy link

joshormond commented Nov 25, 2023

@DanShockley - Just ran into this recently. We also changed from JSONListValues to JSONListKeys, and with that change you can remove that substitution from JSON.ArrayLength also. It is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants