Move payment methods and integrations registration from plugins_loaded to init action
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed` to `init` action to fix loading text domain too early.
remcotolsma
requested changes
Dec 20, 2024
There was a problem hiding this comment.
If this PR gets merged, we would also need to update for example (and maybe also in other places?):
The integrations may be loaded in the plugins_loaded action, but should not use translations at that time? Is it possible to improve this in smaller steps? It is now a bit difficult to see what the consequences of this PR are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix loading the text domain too early, as described in #201.
@remcotolsma I'm not 100% sure if we can safely move from
plugins_loadedtoinit. If this PR gets merged, we would also need to update for example (and maybe also in other places?):setup()will now be called ininit, soplugins_loadedhas already been called at this point)