Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expfmt: need to support gauge histogram metric type and float histogram #430

Open
beorn7 opened this issue Jan 5, 2023 · 1 comment
Open
Assignees

Comments

@beorn7
Copy link
Member

beorn7 commented Jan 5, 2023

The various MetricFamilyTo... functions are currently ignorant of the gauge histogram type recently added to the proto spec. Similarly, they ignore the float fields that got added to support a histogram where the counts are all floats.

Note that this is independent of the new native histograms. (The latter also support float histograms and gauge histograms, but so do the conventional histograms.)

@beorn7 beorn7 self-assigned this Jan 5, 2023
@beorn7
Copy link
Member Author

beorn7 commented Jan 5, 2023

Even if we won't fully support those two new features, we at least have to handle them gracefully. Currently, we just error out with unknown metric type GAUGE_HISTOGRAM in the former case and silently ignore all the floats in the latter case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant