[prometheus] app.kubenetes.io/managed-by is added at install time, and should not be templated
#4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be templated Signed-off-by: Benjamin Leggett <[email protected]>
bleggett
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
Signed-off-by: zeritti <[email protected]>
zeritti
approved these changes
Nov 15, 2024
zanhsieh
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer
app.kubenetes.io/managed-by: Helmis automatically added to deployed resources viahelm install- adding it explicitly during templating is wrong, as templated resources may or may not ultimately actually be installed or managed by Helm.See also:
helmor similar at install time kiali/helm-charts#294Checklist
[prometheus-couchdb-exporter])