Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] improvements to additionalDataSources #4968

Open
romelBen opened this issue Nov 4, 2024 · 0 comments
Open

[kube-prometheus-stack] improvements to additionalDataSources #4968

romelBen opened this issue Nov 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@romelBen
Copy link

romelBen commented Nov 4, 2024

Is your feature request related to a problem ?

This is a small improvement to be made in the kube-prometheus-stack. The feature request is to be able to add external secrets that have been created in Kubernetes in the value additionalDataSources. The example that is provided is using secureJsonData but I don't see this being secure since you would still hard code your secret into your repository.

    - name: GitHub (App)
      type: grafana-github-datasource
      jsonData:
        selectedAuthType: github-app
        appId: 2345252
        installationId: 2342343243
      secureJsonData:
        privateKey: <your_private_key>

Describe the solution you'd like.

The possibility of using a flag for an existing kubernetes secret to be added.

Describe alternatives you've considered.

Currently I'm looking into using secretKeyRef for this to work but I find this to be a pain where I have to mount the secret and reference.

Additional context.

No response

@romelBen romelBen added the enhancement New feature or request label Nov 4, 2024
@zeritti zeritti changed the title kube-prometheus-stack improvements to additionalDataSources [kube-prometheus-stack] improvements to additionalDataSources Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant