Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Prometheus template support for grpcServerTlsConfig in thanos sidecar #4959

Open
v1ctorrhs opened this issue Nov 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@v1ctorrhs
Copy link

v1ctorrhs commented Nov 1, 2024

Is your feature request related to a problem ?

In GCP the ALB implementation enforces TLS encryption for HTTP/2. So when i enable the thanos sidecar currently there's no way to configure the grpcServerTlsConfig which is supposed to make the prometheus operator add the following args for the thanos sidecar

      --grpc-server-tls-cert=""  TLS Certificate for gRPC server, leave blank to
                                 disable TLS
      --grpc-server-tls-client-ca=""
                                 TLS CA to verify clients against. If no
                                 client CA is specified, there is no client
                                 verification on server side. (tls.NoClientCert)
      --grpc-server-tls-key=""   TLS Key for the gRPC server, leave blank to

Describe the solution you'd like.

kube-prometheus-stack:
  prometheus:
    prometheusSpec:
      thanos:
        grpcServerTlsConfig:
         cert:
           configMap: {}
              key: ""
              name: ""
              optional: bool
            secret: {}
              key: ""
              name: ""
              optional: bool
         key:
           configMap: {}
              key: ""
              name: ""
              optional: bool
            secret: {}
              key: ""
              name: ""
              optional: bool
          ca: {}
            configMap: {}
              key: ""
              name: ""
              optional: bool
            secret: {}
              key: ""
              name: ""
              optional: bool

Describe alternatives you've considered.

NONE

Additional context.

No response

@v1ctorrhs v1ctorrhs added the enhancement New feature or request label Nov 1, 2024
@DrFaust92
Copy link
Contributor

Hi, you can pass this via:

prometheus.prometheusSpec.thanos.grpcServerTlsConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants