Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors thrown by Intl formatters #106

Closed
stasm opened this issue Dec 12, 2017 · 3 comments
Closed

Handle errors thrown by Intl formatters #106

stasm opened this issue Dec 12, 2017 · 3 comments

Comments

@stasm
Copy link
Contributor

stasm commented Dec 12, 2017

In cc32a1e we started catching errors thrown by Intl formatters inside of FluentType. Should we report them somehow?

@brettz9
Copy link

brettz9 commented Dec 23, 2017

While you're at it (and I'm new to this, so just wrapping my head around your API now), would it not be useful to have a way of passing in options to the Intl formatters from the JavaScript API as opposed to only within the messages?

@zbraniecki
Copy link
Collaborator

@brettz9 please, take a look at the Fluent tutorial, section on Partial Arguments - http://projectfluent.org/fluent/guide/functions.html#partial-arguments

@stasm
Copy link
Contributor Author

stasm commented Jul 23, 2019

Fixed in #398 on the release branch.

@stasm stasm closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants