Report errors from instantiating Intl objects

projectfluent · Jul 19, 2019 · c9b38d3 · c9b38d3
1 parent 48a11f8
commit c9b38d3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/fluent/src/types.js b/fluent/src/types.js
@@ -65,8 +65,8 @@ export class FluentNumber extends FluentType {
         Intl.NumberFormat, this.opts
       );
       return nf.format(this.value);
-    } catch (e) {
-      // XXX Report the error.
+    } catch (err) {
+      scope.reportError(err);
       return this.value;
     }
   }
@@ -83,8 +83,8 @@ export class FluentDateTime extends FluentType {
         Intl.DateTimeFormat, this.opts
       );
       return dtf.format(this.value);
-    } catch (e) {
-      // XXX Report the error.
+    } catch (err) {
+      scope.reportError(err);
       return this.value;
     }
   }

diff --git a/fluent/test/functions_builtin_test.js b/fluent/test/functions_builtin_test.js
@@ -67,7 +67,8 @@ suite('Built-in functions', function() {
 
       msg = bundle.getMessage('num-bad-opt');
       assert.strictEqual(bundle.formatPattern(msg.value, args, errors), '1');
-      assert.strictEqual(errors.length, 0);
+      assert.strictEqual(errors.length, 1);
+      assert.ok(errors[0] instanceof RangeError); // Invalid option value
     });
 
     test('string argument', function() {
@@ -222,7 +223,8 @@ suite('Built-in functions', function() {
       // may vary depending on the TZ:
       //     Thu Sep 29 2016 02:00:00 GMT+0200 (CEST)
       assert.strictEqual(bundle.formatPattern(msg.value, args, errors), date.toString());
-      assert.strictEqual(errors.length, 0);
+      assert.strictEqual(errors.length, 1);
+      assert.ok(errors[0] instanceof RangeError); // Invalid option value
     });
 
     test('number argument', function() {