From 70b78c5437dc9bab906e26a982e01bc0d593c1c9 Mon Sep 17 00:00:00 2001
From: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Date: Thu, 25 Apr 2024 16:53:03 +0200
Subject: [PATCH] Fix trying to close vpplink on vpp segfault

This patch removes the closing of the vpplink channel
when VPP fails to start as if err != nil, vpp will always
be nil.

Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
---
 vpp-manager/vpp_runner.go | 1 -
 1 file changed, 1 deletion(-)

diff --git a/vpp-manager/vpp_runner.go b/vpp-manager/vpp_runner.go
index 642917c3..8a434329 100644
--- a/vpp-manager/vpp_runner.go
+++ b/vpp-manager/vpp_runner.go
@@ -848,7 +848,6 @@ func (v *VppRunner) runVpp() (err error) {
 	v.vpp = vpp
 	if err != nil {
 		terminateVpp("Error connecting to VPP: %v", err)
-		v.vpp.Close()
 		<-vppDeadChan
 		return fmt.Errorf("cannot connect to VPP after 10 tries")
 	}