fix: don't display divider for API Keys menu item when API key is disabled #433
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled Signed-off-by: Vishwas Rajashekar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 82.70% 83.35% +0.65%
==========================================
Files 63 63
Lines 1885 1887 +2
Branches 485 498 +13
==========================================
+ Hits 1559 1573 +14
+ Misses 315 303 -12
Partials 11 11 ☔ View full report in Codecov by Sentry. |
andaaron
approved these changes
Mar 24, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
Closes #424
What does this PR do / Why do we need it:
This PR fixes a bug where 2 horizontal lines show up in the User Account menu when the API key setting is disabled.
Testing done on this change:
With API keys disabled:
With API keys enabled:
Automation added to e2e:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Not expected to break upgrades or downgrades. Not tested on a cluster.
Does this change require updates to the CNI daemonset config files to work?:
None
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.