Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typos in website directions for auth? #2191

Closed
cboettig opened this issue Jan 28, 2024 · 2 comments · Fixed by project-zot/project-zot.github.io#153
Closed

[Bug]: Typos in website directions for auth? #2191

cboettig opened this issue Jan 28, 2024 · 2 comments · Fixed by project-zot/project-zot.github.io#153
Labels
bug Something isn't working rm-external Roadmap item submitted by non-maintainers

Comments

@cboettig
Copy link

zot version

2.0.1

Describe the bug

Thanks for an amazing project, really fantastic job. Just reporting a small issue in docs.

The URL, https://zotregistry.dev/v2.0.1/articles/authn-authz/#using-google-github-or-gitlab, describes OAuth based authentication with providers including GitHub, but appears to incorrectly state the callback URL, as, e.g.

http://zot.example.com:8080/auth/callback/github

Contrast this to the README in

The callback url which should be used when making oauth2 provider setup is http://127.0.0.1:8080/zot/auth/callback/\<provider\>
which shows an additional zot/ in the path before auth. Testing with the current (2.0.1) release I can confirm this extra bit is necessary.

Note also that going to the docs page without the version in the URL, https://zotregistry.dev/articles/authn-authz/#using-google-github-or-gitlab, we no longer have these instructions at all :(.

To reproduce

See URLs above

Expected behavior

No response

Screenshots

No response

Additional context

No response

@cboettig cboettig added the bug Something isn't working label Jan 28, 2024
@andaaron andaaron added the rm-external Roadmap item submitted by non-maintainers label Jan 29, 2024
@rchincha
Copy link
Contributor

rchincha commented Jan 29, 2024

@cboettig do you want to give us a PR? We strongly encourage community participation.

Documentation for zot is generated from here.
https://github.com/project-zot/project-zot.github.io

@cboettig
Copy link
Author

@rchincha that's awesome, thanks for the link! I've taken a stab at this in project-zot/project-zot.github.io#153. Hopefully I've edited the correct source and didn't mess things up, but critique away, I'm here to learn.

@andaaron andaaron linked a pull request Feb 9, 2024 that will close this issue
@andaaron andaaron closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rm-external Roadmap item submitted by non-maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants