Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ui/vulnerabilities: how many vulnerabilities are there? can we get a summary by severity? #2114

Closed
mikemccracken opened this issue Nov 2, 2023 · 9 comments
Assignees
Labels
bug Something isn't working ui UI-related feature

Comments

@mikemccracken
Copy link
Contributor

zot version

v1.4.3

Describe the bug

the vulns list doesn't have a total count as far as I can tell, and it does dynamic scrolling so the scroll bar is no help.
How many am I looking at?

To reproduce

  1. Configuration
  2. Client tool used
  3. Seen error

Expected behavior

there should be a way to know how many issues we are looking at and how many are of each severity

Screenshots

No response

Additional context

No response

@mikemccracken mikemccracken added the bug Something isn't working label Nov 2, 2023
@andaaron andaaron added the ui UI-related feature label Nov 9, 2023
@andaaron andaaron transferred this issue from project-zot/zot Nov 27, 2023
@bennesp
Copy link

bennesp commented Dec 4, 2023

Shouldn't this has an impact also on the backend? I mean, results are currently paginated. As such, the frontend alone cannot show meaningful counters for each severity. Should we also think of changing the GetCVEListForImage graphql query?

@andaaron
Copy link
Contributor

andaaron commented Dec 5, 2023

Ah, I missed the how many are of each severity in the description.
The total for all severities is already returned.

@andaaron andaaron transferred this issue from project-zot/zui Dec 5, 2023
@mikemccracken
Copy link
Contributor Author

where is the total for all severities? I just looked again at the internal aci-zot02 instance and don't see it.

@andaaron
Copy link
Contributor

andaaron commented Dec 7, 2023

The information on the page returned in the request includes the total number of items as TotalCount.
See this example: https://github.com/project-zot/zot/blob/main/pkg/extensions/search/search.md#list-cves-of-given-image
The UI doesn't show it as far as I know.

@andaaron andaaron self-assigned this Dec 8, 2023
@andaaron
Copy link
Contributor

Backend side: #2131

@andaaron
Copy link
Contributor

andaaron commented Dec 11, 2023

Shouldn't this has an impact also on the backend? I mean, results are currently paginated. As such, the frontend alone cannot show meaningful counters for each severity. Should we also think of changing the GetCVEListForImage graphql query?

I think it's better to update the existing ImageSummary property Vulnerabilities. Since we already have the maximum severity and total CVE count there as well. And that way we can show this data in other places except the CVE list (thinking the "tag" tiles under a repository, for example). We also make the Image query for the image details views, so we could reuse it in the vulnerabilities tab if needed.

@andaaron
Copy link
Contributor

Done in project-zot/zui#416.
@mikemccracken please let us know your feedback.

@mikemccracken
Copy link
Contributor Author

image nice! this is a big improvement. I have a minor further request, I'll file it separately

@andaaron
Copy link
Contributor

Let me close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui UI-related feature
Projects
None yet
Development

No branches or pull requests

4 participants