Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support prometheus-operator? #41

Closed
batazor opened this issue Jun 22, 2024 · 4 comments · Fixed by #45
Closed

Add support prometheus-operator? #41

batazor opened this issue Jun 22, 2024 · 4 comments · Fixed by #45

Comments

@batazor
Copy link
Contributor

batazor commented Jun 22, 2024

This will simplify the process of collecting Prometheus metrics
@rchincha
Copy link
Contributor

@batazor would you like to submit a PR (draft even) to get this started?

@batazor batazor mentioned this issue Jun 24, 2024
Closed
@batazor
Copy link
Contributor Author

batazor commented Jun 24, 2024

@rchincha done

@rchincha
Copy link
Contributor

rchincha commented Aug 2, 2024

@batazor
Pls reopen your PR and fix as per #42 (comment)

@batazor batazor mentioned this issue Aug 2, 2024
Merged
@batazor
Copy link
Contributor Author

batazor commented Aug 2, 2024

@rchincha I can't reopen the past PR, but I've created a new PR with the suggested fixes in mind #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add service monitor
add service monitor
2 participants
@batazor @rchincha