Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase permissiveness of pitch matching for "pitch perfect" #31

Open
plastichotsprings opened this issue Feb 8, 2020 · 0 comments
Open
Labels
bug Something isn't working task Tasks

Comments

@plastichotsprings
Copy link
Member

Combined with the tendency of the pitch detection algorithm to give buggy results, need more permissiveness so that people aren't told that they're not on the pitch as often. Otherwise, users who briefly find their pitch as correctly detected and then immediately move out of the range will have the exercise stopped immediately (along with the message "Nice! 1 second").

another related issue would be to add a feature for users to repeat a level of pitch perfect if there was a mistake in the pitch detection -- rather than forcing users to completely start over. this should not be very difficult to add in.

@plastichotsprings plastichotsprings added bug Something isn't working task Tasks labels Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task Tasks
Projects
None yet
Development

No branches or pull requests

1 participant