Fix rounding error when computing the emulated control stick values #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
approved these changes
Aug 18, 2022
NikhilNarayana
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #344 : Modifier Control Stick key only works when turning to the right. This fixes the issue both for the Gray Stick and the C-Stick.
There was a rounding inconsistency when computing the emulated (Standard Controller) control sticks' values. If the stick was pushed all the way to the max of the axis and the modifier key was pressed, the resulting offset was +63 if the stick was pushed in the positive direction of the axis, but -64 if it was pushed in the negative direction of the axis.
This fix first computes the absolute offsets to get consistent (and "correct") rounding, then computes the final result using the sign of the offset.