Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback build doesn't immediately end when netplay build is running next to it #338

Open
FluentCoding opened this issue Feb 13, 2022 · 0 comments

Comments

@FluentCoding
Copy link
Contributor

Expected Behavior

The main thread of the playback build should stop immediately when being closed.

Current Behavior

When closing the playback build while the netplay build is running next to it, it takes around 10 seconds for the process to stop. You can see this if you follow the steps below with a task manager. This issue originated from: project-slippi/slippi-launcher#231.

Steps to Reproduce

  1. Open the netplay build (through configure netplay build in the slippi launcher e.g.)
  2. Open the playback build
  3. Close the playback build (and you will notice in the task manager that the process is still running for around 10 seconds until it closes itself, except for if you follow step 4 without waiting)
  4. Close the netplay build (which results into both processes being stopped immediately)

Environment

Windows 10 Home 64-bit
Slippi Launcher to open both dolphin builds

Video

The included video shows the step to reproduce the issue in two ways, 1. with waiting for the playback build process to automatically end after closing it and 2. without waiting and closing the netplay build before the playback build process automatically ends.

2022-02-13.10-56-06.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant