Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logout button #277

Open
alanpoon opened this issue Nov 26, 2024 · 4 comments · May be fixed by #293
Open

Add logout button #277

alanpoon opened this issue Nov 26, 2024 · 4 comments · May be fixed by #293
Assignees
@Guocork
Labels
enhancement New feature or request help wanted Looking for help from anyone!
Milestone
Stage 1: basic Ma...

Comments

@alanpoon
Copy link
Contributor

  1. Currently there is no logout button
  2. User need to manually delete session file in order to change account

To do: Add temporary logout button above the setting button or wait for the setting page completed.
@kevinaboos
Copy link
Member

Agree this is nice to have.

Should logging out of a session cause that session file to be deleted? I would think that users don't expect their session to be deleted upon logging out. For that, we can have a separate button that deletes a session (I think other clients call this "Wipe cache", but we can do it in a more fine-grained fashion that allows a user to delete specific saved sessions)

@kevinaboos kevinaboos changed the title Add Logout button Add ways to log out and to delete specific saved sessions Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Ready in Robrix Nov 26, 2024
@kevinaboos kevinaboos added enhancement New feature or request help wanted Looking for help from anyone! labels Nov 26, 2024
@kevinaboos kevinaboos changed the title Add ways to log out and to delete specific saved sessions Add logout button Dec 17, 2024
@kevinaboos
Copy link
Member

Adding ways to manage local sessions on disk is part of Stage 2 milestone, not stage 1. We should separate that out into a separate issue.

@Guocork
Copy link
Contributor

Guocork commented Dec 18, 2024

I'll take care of this task. Please assign the issue to me.

@kevinaboos
Copy link
Member

Great, thanks so much!

@kevinaboos kevinaboos moved this from Ready to In progress in Robrix Jan 3, 2025
@kevinaboos kevinaboos linked a pull request Jan 3, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guocork Guocork

Labels
enhancement New feature or request help wanted Looking for help from anyone!
Projects
Robrix
Status: In progress
Milestone
Stage 1: basic Matrix features
Development

Successfully merging a pull request may close this issue.

add logout feature Guocork/robrix
3 participants
@kevinaboos @alanpoon @Guocork