Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Extract_Names Function in Base Reconciler Should Remove Invisible Unicode #185

Open
1 task
kkdavis14 opened this issue Dec 12, 2024 · 0 comments · May be fixed by #186
Open
1 task

[Bug]: Extract_Names Function in Base Reconciler Should Remove Invisible Unicode #185

kkdavis14 opened this issue Dec 12, 2024 · 0 comments · May be fixed by #186
Assignees
Labels
bug The code does not behave as expected / designed development Medium Medium priority task

Comments

@kkdavis14
Copy link
Contributor

kkdavis14 commented Dec 12, 2024

Priority Level

Medium

What happened?

Some YUL primary names have "\u200f" hiding in them, this prevents name reconciliation to name indices. We can remove them during reconciliation, but leave them in the source records in case they're necessary. There may be other invisible unicodes than this occurring, so fix should use regex to check for them.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Additional Tasks

  • Add line in base reconciler to find and replace this unicode string.
@kkdavis14 kkdavis14 added bug The code does not behave as expected / designed Medium Medium priority task labels Dec 12, 2024
@kkdavis14 kkdavis14 self-assigned this Dec 12, 2024
@kkdavis14 kkdavis14 changed the title [Bug]: Extract_Names Function in Base Reconciler Should Remove RLM Unicode [Bug]: Extract_Names Function in Base Reconciler Should Remove Invisible Unicode Dec 12, 2024
@kkdavis14 kkdavis14 linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not behave as expected / designed development Medium Medium priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant