Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor instructorize method in User model #49

Open
jaeaster opened this issue Oct 15, 2017 · 0 comments
Open

Refactor instructorize method in User model #49

jaeaster opened this issue Oct 15, 2017 · 0 comments
Assignees
@jaeaster @wpeery

Comments

@jaeaster
Copy link
Contributor

Instructorize is messy, unreadable and has unwanted side effects.

We should be using the machine user for all admin-specific organization reads/writes and not the instructors github privileges. Furthermore, we should only ask for the standard user:email scope from our users instead of user:email, admin:org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaeaster jaeaster

@wpeery wpeery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaeaster @wpeery