Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring suggestions #18

Open
nfx8 opened this issue Apr 16, 2013 · 2 comments
Open

Some refactoring suggestions #18

nfx8 opened this issue Apr 16, 2013 · 2 comments

Comments

@nfx8
Copy link

nfx8 commented Apr 16, 2013

The goxapi.py has 1696 LOC. I'm going to use parts of goxapi and refactor a module, so that it is independent of the UI and the exchange. I would split up the goxapi.py in orders.py (Order and Orderbook classes), exc_cllients.py (BaseClient and SocketIO / Websocket classes), config.py (Secret, Goxconfig classes), util.py (number conversions and pretty_format).

The Gox object is an active streaming object (start method), as well as a passive broker to the exchange. A request sometimes can not only be a streaming request, but a one time request.

I can do a pull request if there is interest. It makes sense to have one great MtGox API out there, where then everyone can add their own stuff ontop. goxtool this is certainly the best existing code for interfacing with MtGox and I would like to contribute to a common base.

@prof7bit
Copy link
Owner

maybe its best to create a fork and develop that as a separete project. I didn't intend to make the one and ultimate complete reference API that implements everything, its just a small subset of things needed for goxtool and inspiration for bigger projects that move into different directions.

@nfx8
Copy link
Author

nfx8 commented Apr 17, 2013

sure. will do. thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants