Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base versioned commit on the tip of the PR head branch #1052

Merged
merged 1 commit into from
May 16, 2024
Merged

Base versioned commit on the tip of the PR head branch #1052

merged 1 commit into from
May 16, 2024

Commits on May 16, 2024

  1. Base versioned commit on the tip of the PR head branch 

    Historically we have used the PR merge commit, which is the GitHub
default, to ensure that we are testing the same merges that will
be committed to the target branch.

However, we already require that branches be rebased on the
target before merging via branch protections so there is no benefit
gained from using the merge commit.

We also would like to enable use cases where we are testing against
old versions of the target branch and not include changes from the tip
of the target.

Change-type: major
Signed-off-by: Kyle Harding <[email protected]>
    @klutchell
    klutchell committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2d9d2a3 View commit details
    Browse the repository at this point in the history