Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken backlinks to p5.js Reference after launching the new web #617

Open
igor-kamil opened this issue Oct 28, 2024 · 0 comments
Open

Broken backlinks to p5.js Reference after launching the new web #617

igor-kamil opened this issue Oct 28, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@igor-kamil
Copy link

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Mac OS

Web browser and version

No response

Actual Behavior

Since the recent update to the p5.js website, existing links to the reference pages have broken due to the URL structure change. Links that previously followed the format e.g. https://p5js.org/reference/#/p5/image now need to point to: https://p5js.org/reference/p5/image/.

  1. This change has caused many links to the p5.js reference documentation across various online materials to break. Updating all of these links across the internet is unrealistic, and they remain inaccessible to users.
  2. Some error messages in the editor contain links to the reference, which are now broken. For example:
Screenshot 2024-10-28 at 17 56 50

Since it only requires removing the /#/ from the URLs, I hope it might be a straightforward change.

Suggestions:

  1. Implement a redirect from https://p5js.org/reference/#/p5/* to https://p5js.org/reference/p5/* on the server / host config.
  2. Add script to handle it (or resolver script to handle unmatched routes).

Overall, I appreciate the improvements to the site after the update. Apologies for not opening a PR myself—I’m not familiar with Astro, but I’d be happy to assist with testing or other support if needed.

Expected Behavior

Links to reference pages, both in online materials and editor error messages, should work as before, directing users to the correct reference documentation without broken URLs.

Steps to reproduce

https://p5js.org/reference/#/p5/image should redirect to -> https://p5js.org/reference/p5/image/

Would you like to work on the issue?

yes

@igor-kamil igor-kamil added the Bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant