Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When non-English is selected, “Related Reference” on the Example page is not displayed. #555

Open
shibomb opened this issue Sep 18, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@shibomb
Copy link
Contributor

shibomb commented Sep 18, 2024

Most appropriate sections of the p5.js website?

Examples

What is your operating system?

None

Web browser and version

No response

Actual Behavior

When non-English is selected, “Related Reference” on the Example page is not displayed.
スクリーンショット 2024-09-19 4 16 37

Expected Behavior

When non-English is selected, “Related Reference” on the Example page is displayed.

Steps to reproduce

Compare the bottom of the example page between English and non-English.
e.g.
https://p5js.org/examples/shapes-and-color-shape-primitives/
https://p5js.org/es/examples//shapes-and-color-shape-primitives/

Would you like to work on the issue?

someone

@shibomb shibomb added the Bug Something isn't working label Sep 18, 2024
@shibomb
Copy link
Contributor Author

shibomb commented Sep 18, 2024

Also, the subtitle “Related Reference” does not seem to translate.
I suggest the plural “Related References”.

@xuv
Copy link

xuv commented Oct 30, 2024

@shibomb I don't see this bug anymore. It seems to have resolved itself.

I looked at the pages you link to and they have "related references" in all languages afaict. I read Spanish and could definitely see it there.

It has been changed to its plural form also.

So I suppose this issue can be closed

@shibomb
Copy link
Contributor Author

shibomb commented Oct 31, 2024

@xuv Thanks for your comment!

In my environment, it still does not show up when I select non-English.
(The plural when select English was fixed.)

After your report, I checked it again thoroughly.
Then I found that there is no “relatedReference:” in the source code except in English.

In other words, it seems to be correct that it is not displayed!
(I am working on translating the Japanese version, but since it was based on the English version, I was not aware of that. My apologies.)

@shibomb
Copy link
Contributor Author

shibomb commented Oct 31, 2024

Upon further inspection, the “relatedReference:” is present only on the “00_Shape_Primitives” page, even in the English version.
It does not exist on any other Example pages.

If “relatedReference:” is reflected in other pages and non-English pages in the future, it will be displayed.
(I just tried it on the Spanish version of my local environment and it does show up.)

Or maybe the fact that only “00_Shape_Primitives” has “relatedReference:” is some kind of test?


Does anyone know the policy on this?

If the above is not a problem in the current situation, please close this Issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants