Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing and linting examples #1370

Open
nickmcintyre opened this issue Jun 2, 2023 · 2 comments
Open

Editing and linting examples #1370

nickmcintyre opened this issue Jun 2, 2023 · 2 comments

Comments

@nickmcintyre
Copy link
Member

nickmcintyre commented Jun 2, 2023

Topic

Hello! I propose editing the examples so that they adhere to the Airbnb JavaScript Style Guide. For example, Forces would be clearer with modern syntax.

@limzykenneth @davepagurek what do you think about incorporating the sample linter from the library into the website's build system?

@limzykenneth
Copy link
Member

I'm happy to go with the Airbnb style which is somewhat close to what we have already.

The sample linter in the library repo was written to very specifically lint inline documentation's code example, for the website example you can lint the example js files directly so it may not be required. I'll leave the implementation detail up to you and we can review when a PR is filed.

@davepagurek
Copy link
Contributor

That all sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants