Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't reproduce AE-LC numbers in hf ckpt(Llama-3-8b-SFT-DPO, Llama-3-8b-SFT-SimPO)) #77

Open
schrieffer-z opened this issue Dec 2, 2024 · 2 comments

Comments

@schrieffer-z
Copy link

  1. vllm under any version mismatch with current env and if you separate eval and train. I still need a version of vllm
  2. in separate env, using the command below, I try different engine (4o and 4-turbo) and get some numbers dose not make sense. Have you ever try different annotators when use 4o, it give me a result where DPO>SimPO, while 4-turbo gives the opposite
    image

alpaca_eval evaluate_from_model
--model_configs /mnt/vepfs/fs_users/***/xAI-RLHF/***/SimPO/eval/alpacaeval2/configs/Llama-3-Base-8B-SFT-SimPO.yaml
--annotators_config weighted_alpaca_eval_gpt4_turbo\

@schrieffer-z
Copy link
Author

repo's AE-LC number:
simpo - 22%
dpo - 18.2%

@lancerts
Copy link

lancerts commented Dec 2, 2024

Had a similar issue with ckpt [princeton-nlp/Llama-3-Instruct-8B-SimPO-v0.2](https://huggingface.co/princeton-nlp/Llama-3-Instruct-8B-SimPO-v0.2)
3 AE runs gives consistent LC/WR (48/44) where the number reported is 53.7/47.5.
One potential issue could be #75 and there is no vllm version specified in https://github.com/princeton-nlp/SimPO/blob/main/environment.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants