fix: comments

primev · Aug 13, 2024 · ab10db8 · ab10db8
1 parent 6257bfe
commit ab10db8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -216,4 +216,3 @@ jobs:
       - go-modules
       - foundry
       - contracts
-
diff --git a/testing/cmd/main.go b/testing/cmd/main.go
@@ -21,8 +21,10 @@ var (
 		Required: true,
 		EnvVars:  []string{"MEV_COMMIT_TEST_SETTLEMENT_RPC_ENDPOINT"},
 		Action: func(_ *cli.Context, s string) error {
-			_, err := url.Parse(s)
-			return fmt.Errorf("invalid settlement RPC endpoint: %w", err)
+			if _, err := url.Parse(s); err != nil {
+				return fmt.Errorf("invalid settlement RPC endpoint: %w", err)
+			}
+			return nil
 		},
 	}
 
@@ -32,8 +34,10 @@ var (
 		Required: true,
 		EnvVars:  []string{"MEV_COMMIT_TEST_L1_RPC_ENDPOINT"},
 		Action: func(_ *cli.Context, s string) error {
-			_, err := url.Parse(s)
-			return fmt.Errorf("invalid L1 RPC endpoint: %w", err)
+			if _, err := url.Parse(s); err != nil {
+				return fmt.Errorf("invalid L1 RPC endpoint: %w", err)
+			}
+			return nil
 		},
 	}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -216,4 +216,3 @@ jobs:
		- go-modules
		- foundry
		- contracts