We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As suggested in #71:
I would like to suggest a minimum contribution guide with our agreement on code stye and best practices for this project. Long story short my suggestions would be: ES6 compliant any consolidate code style guide something like Browserify and Babel to generate the browser/CDN .min.js (haven't checked the current gulpfile.js but maybe it's already there) By consolidated I mean anything compatible with JSLlint. IMHO in spite f the semicolons I'd go with Airbnb. What do you think about it? Here is how I plan to review this PR: we could agree on something among these lines in terms of best practices and code style we add that to README.md (or create CONTRIBUTING.md if it gets too long once again) finally I'll have stuff other than my own opinion to dive into code Hey @flaviosilveira, jump in!
I would like to suggest a minimum contribution guide with our agreement on code stye and best practices for this project.
Long story short my suggestions would be:
.min.js
gulpfile.js
By consolidated I mean anything compatible with JSLlint. IMHO in spite f the semicolons I'd go with Airbnb.
What do you think about it? Here is how I plan to review this PR:
README.md
CONTRIBUTING.md
Hey @flaviosilveira, jump in!
The text was updated successfully, but these errors were encountered:
Hey, @cuducos welcome back bro! 🤘
Yes! I approve your all suggestions and complement the check list:
As for this Pull Request (#71), I think it's just to remove prototype files and implement some things from ES6 in GulpJS files...
We can continue this discussion for new projects ;)
Sorry, something went wrong.
No branches or pull requests
As suggested in #71:
The text was updated successfully, but these errors were encountered: