Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert showing infinitely in case if vendor tries to access more tables(Open, Queue & Closed) data and either device is not connected to the internet or received any API error. #159

Open
pankajatocdlab opened this issue Jun 17, 2019 · 1 comment

Comments

@pankajatocdlab
Copy link
Contributor

Expected Behavior

Alert should be shown only once in case of error while getting more vendor tables(Open, Queue & Closed) data by scrolling the list(s).

Actual Behavior

If error occurred while getting more vendor tables(Open, Queue & Closed) data by scrolling the list(s) then alert is showing infinitely.

@pankajatocdlab pankajatocdlab self-assigned this Jun 17, 2019
@pankajatocdlab pankajatocdlab changed the title Alert showing infinitely in case if vendor tries to access more tables(Open, Queue & Closed) data and device is not connected to the internet. Alert showing infinitely in case if vendor tries to access more tables(Open, Queue & Closed) data and either device is not connected to the internet or received any API error. Jun 17, 2019
@pankajatocdlab
Copy link
Contributor Author

FYI @ishmael, I have created a new branch named autofill-vendor-tables-issue on git in which I have resolved Alert showing infinitely in case of error(either device is disconnected from internet or any API error) when vendor tries to load more tables(Open, Queue & Closed) data by scrolling the list(s) issue. In brief what I did?

  • On scrolling the vendor tables(Open, Queue & Closed) list(s), show the indicator at the bottom of the list to indicate that data is fetching from API, on success append the newly fetched items in the existing list and so on. Incase of error(either device is not connected to the internet or any API error), show a button named Tap to retry at the bottom of the list and now user can fetch more data by clicking on Tap to retry button. After selecting the Tap to retry button if no error occurred then hide the Tap to retry button and append the received data in the existing list.
    I have created autofill-vendor-tables-issue branch from call-waiter-expo-upgraded branch because call-waiter-expo-upgraded have the latest code. Please review the PR(Feature/159/autofill vendor tables issue #160).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant