Check what the current context is before we reset the prompt #56
Conversation
|
Oooh a fix! 😁 I may pick your brain in gitter about this and write up a comment. These two lines have been such a source of trouble. |
|
@paulmelnikow is this ok to be merged? |
|
Since this block of code has been such a source of trouble, I'd prefer to include an explanation of why it's doing what it's doing. Don't feel that strongly though. |
|
I can include that later today. Still unsure whether this is intended behaviour by @sorin-ionescu or if this is a genuine bug. Also, would like clarification around whether this is still being maintained as I don't see value in merging changes here if we need to make the same PR's elsewhere.
… On Mar 12, 2017, at 23:18, Paul Melnikow ***@***.***> wrote:
Since this block of code has been such a source of trouble, I'd prefer to include an explanation of why it's doing what it's doing. Don't feel that strongly though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
We could put merging on pause. As I mentioned in #44 I don’t see much benefit in pushing forward on a community fork given Sorin is willing to add maintainers. |
|
@paulmelnikow I think it's beneficial to keep improving this fork while things are being sorted out, otherwise it begins to look like we have two abandoned projects :) Honestly I think it makes sense to keep the code in the org, it doesn't depend as much on one single person and moreover it is already 90+ commits ahead. A nice thing Sorin could do if he wishes is to make this project the primary one, so that github redirects from |
|
Looks like this will be addressed at sorin-ionescu#1272. |
Resolves #4