use $(PRET) tools install #813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the include path for compilation with agbcc, to use the pret headers instead of the devkitPro headers. |
PikalaxALT
reviewed
Sep 26, 2019
| ifneq ($(OS),Windows_NT) | ||
| UNAME := $(shell uname -s) | ||
| ifeq ($(UNAME),Darwin) | ||
| HOSTCC := /usr/bin/clang |
There was a problem hiding this comment.
uh, yes. the gcc command is ambiguous asf on macOS. we should stick to the system compiler unless otherwise specified
PikalaxALT
reviewed
Sep 26, 2019
| @@ -75,49 +102,33 @@ endif | |||
|
|
|||
| CPPFLAGS := -iquote include -Wno-trigraphs -DMODERN=$(MODERN) | |||
| ifeq ($(MODERN),0) | |||
| CPPFLAGS += -I tools/agbcc/include -I tools/agbcc | |||
| CPPFLAGS += -I $(PRET)/include -I $(PRET) | |||
There was a problem hiding this comment.
Add -nostdinc -undef here
PikalaxALT
reviewed
Sep 26, 2019
| # -*- coding: utf-8 -*- | ||
| ## Convenience script for installing all the tools at once | ||
|
|
||
| REPO='https://pkg.caveoforig.in/fhtk/'; |
There was a problem hiding this comment.
Would be better to have the repo point back to pret on github, or to some host maintained by pret keyholders.
PikalaxALT
reviewed
Sep 26, 2019
| _sudo=''; | ||
| fi | ||
|
|
||
| _cwd="${PWD}"; |
There was a problem hiding this comment.
use pushd and popd instead
There was a problem hiding this comment.
thanks i forgot about those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use
clangon macOS, becausegcccan be really wonky with homebrew sometimes.The main feature is the migration of tools out of the local directory they’re installed in and into a folder
/opt/pret/. This makes it easy to move the tools around or use different versions for diagnostics. It also allows people to download precompiled binaries of the tools, which I have made available on the Cave of Origin for Linux and macOS using thegrupstool.I’m open to seeing the tools moved to the pret GitHub organisation, and this is how
agbccis already handled, but for now they exist under the Fanhacker’s Toolkit because it’s an org I have control over. I have tested this with a clean repo usingmake -j$(nproc) && make compareand get an OK, using the tools downloaded from the Cave using theinstall-all.shconvenience script provided by grups. Let me know how it handles for you.